Resolume Forum

Attempting to read a union member that is not the last one written is undefined behaviour...

Is it "more undefined" than re-casting a void* ? Maybe.

Is re-casting between unsigned int (32 bits) and a pointer (how many bits?..) "safe"?

This is the the way the FFGL interface seems to work. Is there ...

I've posted my current Work In Progress

http://subpixels.com/resolume/ffgl/wip/

spxl-resolume-ffgl-source-2019-07-22.zip - 522 kB

Stronger Typing
Scoped enumerations replace "static const FFUInt32" definitions for Function codes. Plugin types, Parameter types, Parameter usage, Input status ...

Passing/returning ranges
My guess is that calls always check the result as if (result.UIntValue == FF_FAIL) before trying to cast the result as anything else.

Shared pointer
The pointers in your Plugin subclass can be regular pointers. The (main class) Plugin destructor can clean up the data ...

Maybe when I try putting derived classes in a vector I will find why shared pointers are "necessary"... It has occurred to me that the vector would have to be a vector of pointers, not a vector of objects. I will have to think about this more and find out as I play with it. My previous thinking was ...

Pointer recasting in FFGL.cpp :
Thanks for the feedback.

Passing/returning ranges :
The idiom is to return FF_FAIL on error (bit pattern for -1 cast as a uint32), else a pointer to the struct with the data. eg see things like return (char*)FF_FAIL.

BeatInfostruct :
Don't beat yourself up ...

subpixel: Is it just me, or is the code in the ffglquickstart more or less duplicating the original structures. Can we not just extend the original structures without keeping separate copies of all the data? It is all very confusing right now. Also, can we do away with the "Ptr" classes and just ...

subpixel: SetBeatinfoStruct members should be type float, right?

Menno: yes one float for bpm and one for barPhase

subpixel: I mean declared as float, not declared as FFMixed.
// SetBeatinfoStruct
// 2019-07-12 ffgl@subpixels.com - changed bpm and barPhrase types from FFMixed to float
typedef ...

subpixel: It seems that getParamRange() is using the FFMixed inputValue argument to store the requested data, whereas everything else seems to use the FFMixed retval variable - what gives?

Menno: I'm not quite sure i understand what you mean, but the RangeStruct is a complex return type that cannot ...

subpixel: Why is this nasty pointer recasting code still all up in my face? (FFGL.cpp)

Menno: Plugins aren't expected to interact with FFGL.cpp. Plugins are expected to use the FFGLPluginSDK.h as their entrypoint into the ffgl sdk. FFGL's internals require all this pointer casting because ffgl uses ...

I was under the impression that the team at Resolume created the latest versions of the SDK. Am I mistaken?

Why not just make the changes you want?

The change to OpenGL 4 seems to be a major breaking change, so why not change the small stuff like parameter names?

PS: In case it didn't come across ...